Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-26 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 07:40:31AM -0600, Corey Minyard wrote: > On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: > >> On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: > >>> On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 07:40:31AM -0600, Corey Minyard wrote: > On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: > > On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: > >> On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: > >>> On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Corey Minyard
On 11/14/2013 07:38 AM, Michael S. Tsirkin wrote: > On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: >> On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: >>> On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: Postpone the addition of the ACPI and SMBIOS tables until a

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Michael S. Tsirkin
On Thu, Nov 14, 2013 at 07:28:00AM -0600, Corey Minyard wrote: > On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: > > On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: > >> Postpone the addition of the ACPI and SMBIOS tables until after > >> device initialization. This allows devices

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-14 Thread Corey Minyard
On 11/14/2013 01:30 AM, Michael S. Tsirkin wrote: > On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: >> Postpone the addition of the ACPI and SMBIOS tables until after >> device initialization. This allows devices to add entries to these >> tables. >> >> Signed-off-by: Corey Minyard

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-13 Thread Michael S. Tsirkin
On Tue, Nov 12, 2013 at 10:33:13AM -0600, Corey Minyard wrote: > Postpone the addition of the ACPI and SMBIOS tables until after > device initialization. This allows devices to add entries to these > tables. > > Signed-off-by: Corey Minyard Why delay adding FW_CFG_ACPI_TABLES? These are normall

Re: [Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-13 Thread Bret Ketchum
Had trouble with this one: git apply --verbos --check ../ipmi-patches/290708.mbox Checking patch hw/i386/pc.c... Hunk #1 succeeded at 622 (offset 15 lines). error: while searching for: fw_cfg_add_i16(fw_cfg, FW_CFG_MAX_CPUS, (uint16_t)apic_id_limit); fw_cfg_add_i32(fw_cfg, FW_CFG_ID,

[Qemu-devel] [PATCH 14/16] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-11-12 Thread Corey Minyard
Postpone the addition of the ACPI and SMBIOS tables until after device initialization. This allows devices to add entries to these tables. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/hw