Re: [Qemu-devel] [PATCH 14/14] libqos/ahci: create libqos/ahci.c

2015-01-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 13/01/2015 04:34, John Snow wrote: >> +tests/ahci-test$(EXESUF): tests/ahci-test.o $(libqos-pc-obj-y) \ >> + tests/libqos/ahci.o > > Why not add this to libqos-pc-obj-y or libqos-obj-y? > >> >> + * Allocate space in the guest using information

Re: [Qemu-devel] [PATCH 14/14] libqos/ahci: create libqos/ahci.c

2015-01-19 Thread John Snow
On 01/19/2015 12:15 PM, Paolo Bonzini wrote: On 13/01/2015 04:34, John Snow wrote: +tests/ahci-test$(EXESUF): tests/ahci-test.o $(libqos-pc-obj-y) \ + tests/libqos/ahci.o Why not add this to libqos-pc-obj-y or libqos-obj-y? No strong reason, it's just that I am

Re: [Qemu-devel] [PATCH 14/14] libqos/ahci: create libqos/ahci.c

2015-01-19 Thread Paolo Bonzini
On 13/01/2015 04:34, John Snow wrote: > +tests/ahci-test$(EXESUF): tests/ahci-test.o $(libqos-pc-obj-y) \ > + tests/libqos/ahci.o Why not add this to libqos-pc-obj-y or libqos-obj-y? > > + * Allocate space in the guest using information in the AHCIQState object. > + */

[Qemu-devel] [PATCH 14/14] libqos/ahci: create libqos/ahci.c

2015-01-12 Thread John Snow
With global state removed, code responsible for booting up, verifying, and initializing the AHCI HBA is extracted and inserted into libqos/ahci.c, which would allow for other qtests in the future to quickly grab a meaningfully initialized reference to an AHCI HBA. Even without other users, functio