Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:44 PM, Anthony Liguori wrote: > On 03/07/2011 07:27 AM, Stefan Hajnoczi wrote: >> >> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori >>  wrote: >> >>> >>> +def print_definition(name, required, optional, retval): >>> >> >> This function is pretty long.  Is there a logical w

Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-07 Thread Anthony Liguori
On 03/07/2011 07:27 AM, Stefan Hajnoczi wrote: On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: +def print_definition(name, required, optional, retval): This function is pretty long. Is there a logical way to split it up into several smaller meaningful functions? It seem

Re: [Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-07 Thread Stefan Hajnoczi
On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori wrote: > +def print_definition(name, required, optional, retval): This function is pretty long. Is there a logical way to split it up into several smaller meaningful functions? Stefan

[Qemu-devel] [PATCH 13/22] qapi: add code generators for QMP command marshaling

2011-03-06 Thread Anthony Liguori
This generates qmp.h which contains the declarations of all of QMP functions to be dispatched, plus a function that registers marshallers for each of the QMP functions. Signed-off-by: Anthony Liguori diff --git a/Makefile b/Makefile index 8f3a4d3..47a755d 100644 --- a/Makefile +++ b/Makefile @@