Re: [Qemu-devel] [PATCH 13/15] tap-solaris: Convert tap_open() to Error

2015-05-15 Thread Markus Armbruster
Eric Blake writes: > On 05/12/2015 06:03 AM, Markus Armbruster wrote: >> Fixes inappropriate use of syslog(). >> >> Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs >> added instead. > > At least you're admitting where the code is still bad. Actually, git-rm felt pretty tem

Re: [Qemu-devel] [PATCH 13/15] tap-solaris: Convert tap_open() to Error

2015-05-14 Thread Eric Blake
On 05/12/2015 06:03 AM, Markus Armbruster wrote: > Fixes inappropriate use of syslog(). > > Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs > added instead. At least you're admitting where the code is still bad. > > Signed-off-by: Markus Armbruster > --- > net/tap-solari

[Qemu-devel] [PATCH 13/15] tap-solaris: Convert tap_open() to Error

2015-05-12 Thread Markus Armbruster
Fixes inappropriate use of syslog(). Not fixed: leaks on error paths, suspicious non-fatal errors. FIXMEs added instead. Signed-off-by: Markus Armbruster --- net/tap-solaris.c | 59 --- 1 file changed, 30 insertions(+), 29 deletions(-) diff