Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-25 Thread Paul Brook
> I must say I'd like to get rid of the chunking transfer in scsi-disk. > To have it for scsi-disk only is really pointless, as you can > potentially send exactly the same commands via scsi-generic. > So for scsi-generic to work properly qemu need to be able to > allocate the _entire_ data buffer.

Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-25 Thread Hannes Reinecke
On 11/25/2010 04:29 PM, Christoph Hellwig wrote: > On Thu, Nov 25, 2010 at 09:53:25AM +0100, Hannes Reinecke wrote: >> Looked into it. >> Sure I could be doing it for scsi-disk; for scsi-generic it won't >> work, though. And it's not much of a code-share to have from it; >> you'll end up with somet

Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-25 Thread Christoph Hellwig
On Thu, Nov 25, 2010 at 09:53:25AM +0100, Hannes Reinecke wrote: > Looked into it. > Sure I could be doing it for scsi-disk; for scsi-generic it won't > work, though. And it's not much of a code-share to have from it; > you'll end up with something like: Yes, and that is a good start to completely

Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-25 Thread Hannes Reinecke
On 11/24/2010 05:52 PM, Christoph Hellwig wrote: > On Wed, Nov 24, 2010 at 12:16:08PM +0100, Hannes Reinecke wrote: >> Add callback to create a request with a predefined iovec. >> This is required for drivers which can use the iovec >> of a command directly. > > What happend to my comment that the

Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 12:16:08PM +0100, Hannes Reinecke wrote: > Add callback to create a request with a predefined iovec. > This is required for drivers which can use the iovec > of a command directly. What happend to my comment that the iov and non-iov case should share code? Also what happen

[Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-24 Thread Hannes Reinecke
Add callback to create a request with a predefined iovec. This is required for drivers which can use the iovec of a command directly. Signed-off-by: Hannes Reinecke --- hw/scsi-disk.c| 25 + hw/scsi-generic.c | 44 +--- hw/s