Re: [Qemu-devel] [PATCH 13/14] target-mips: fix TLBR wrt SEGMask

2012-10-10 Thread Richard Henderson
On 10/09/2012 01:27 PM, Aurelien Jarno wrote: > tag = env->CP0_EntryHi & ~mask; > VPN = tlb->VPN & ~mask; > +#if defined(TARGET_MIPS64) > +tag &= env->SEGMask; > +#endif > /* Check ASID, virtual page number & size */ Indentation. r~

[Qemu-devel] [PATCH 13/14] target-mips: fix TLBR wrt SEGMask

2012-10-09 Thread Aurelien Jarno
Like r4k_map_address(), r4k_helper_tlbp() should use SEGMask to mask the address. Signed-off-by: Aurelien Jarno --- target-mips/op_helper.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index 6ce27c1..ad5d1c2 100644 --- a/target-mi