Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 11:29:10AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 19:22 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 09:58:17AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 09:

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 19:22 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 09:58:17AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > > > > On Sun, 2012-06-10 at 17:54

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 09:58:17AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 08:

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 18:37 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > > > > On Sun, 2012-06-10 at 17:03

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 09:15:10AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > > > On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > > > > On Sun, Jun 10, 2012 at 07:

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 17:54 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > > On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > > > > vfio_pci.c contain

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 08:41:03AM -0600, Alex Williamson wrote: > On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > > > vfio_pci.c contains a nice function called "parse_hostaddr". You > > > > > may >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 17:03 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > > vfio_pci.c contains a nice function called "parse_hostaddr". You > > > > may > > > > guess what it does. ;) > > > > >>> > > > > >>> Interesting. Wh

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 07:41:51AM -0600, Alex Williamson wrote: > > > vfio_pci.c contains a nice function called "parse_hostaddr". You may > > > guess what it does. ;) > > > >>> > > > >>> Interesting. Why? This looks strange to me: > > > >>> I would expect the admin to bind a device to v

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:35, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > >> Add a property to receive a fully qualified PCI device address. > >> > >> Will be used by KVM device assignment. > >> > >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Alex Williamson
On Sun, 2012-06-10 at 15:01 +0300, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 01:25:41PM +0200, Jan Kiszka wrote: > > On 2012-06-10 13:17, Michael S. Tsirkin wrote: > > > On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: > > >> On 2012-06-10 12:58, Michael S. Tsirkin wrote: > > >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:25:41PM +0200, Jan Kiszka wrote: > On 2012-06-10 13:17, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 12:58, Michael S. Tsirkin wrote: > >>> On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 13:17, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: >> On 2012-06-10 12:58, Michael S. Tsirkin wrote: >>> On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: On 2012-06-10 12:49, Michael S. Tsirkin wrote: > On Sun, Jun 10, 20

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:00:35PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:58, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 12:49, Michael S. Tsirkin wrote: > >>> On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:58, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: >> On 2012-06-10 12:49, Michael S. Tsirkin wrote: >>> On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: On 2012-06-10 11:35, Michael S. Tsirkin wrote: > On Mon, Jun 04, 20

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:52:45PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:49, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:35, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > A

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:49, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: >> On 2012-06-10 11:35, Michael S. Tsirkin wrote: >>> On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: Add a property to receive a fully qualified PCI device address. >>

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:14:36PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:35, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > >> Add a property to receive a fully qualified PCI device address. > >> > >> Will be used by KVM device assignment. > >> > >

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:35, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: >> Add a property to receive a fully qualified PCI device address. >> >> Will be used by KVM device assignment. >> >> Signed-off-by: Jan Kiszka > > I'd like to ponder this a bit more. Wha

Re: [Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:21AM +0200, Jan Kiszka wrote: > Add a property to receive a fully qualified PCI device address. > > Will be used by KVM device assignment. > > Signed-off-by: Jan Kiszka I'd like to ponder this a bit more. What bothers me is that this mixes two things: - ad

[Qemu-devel] [PATCH 13/13] qdev-properties: Add pci-devaddr property

2012-06-04 Thread Jan Kiszka
Add a property to receive a fully qualified PCI device address. Will be used by KVM device assignment. Signed-off-by: Jan Kiszka --- hw/qdev-properties.c | 48 hw/qdev.h|3 +++ 2 files changed, 51 insertions(+), 0 deletions(-)