Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

2014-02-13 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 10/02/2014 16:28, Eric Blake ha scritto: | On 02/10/2014 07:20 AM, Markus Armbruster wrote: |> Argument is null when visiting an unboxed struct. I can't see |> such a visit in the current code. Fix it anyway. | | Is this a sign of missing testsui

Re: [Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

2014-02-10 Thread Eric Blake
On 02/10/2014 07:20 AM, Markus Armbruster wrote: > Argument is null when visiting an unboxed struct. I can't see such a > visit in the current code. Fix it anyway. Is this a sign of missing testsuite coverage? > > Signed-off-by: Markus Armbruster > --- > qapi/opts-visitor.c | 4 +++- > 1 fil

[Qemu-devel] [PATCH 13/13] qapi: Add missing null check to opts_start_struct()

2014-02-10 Thread Markus Armbruster
Argument is null when visiting an unboxed struct. I can't see such a visit in the current code. Fix it anyway. Signed-off-by: Markus Armbruster --- qapi/opts-visitor.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 96ed858