Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-21 Thread Hannes Reinecke
On 11/20/2010 02:25 AM, adq wrote: > On 20 November 2010 00:41, Nicholas A. Bellinger wrote: >> On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: >>> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: aio_ioctl is emulated anyway and currently broken. >>> >>> What

Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-20 Thread adq
On 20 November 2010 08:23, Nicholas A. Bellinger wrote: > On Sat, 2010-11-20 at 01:25 +, adq wrote: >> On 20 November 2010 00:41, Nicholas A. Bellinger >> wrote: >> > On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: >> >> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke w

Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-20 Thread Nicholas A. Bellinger
On Sat, 2010-11-20 at 01:25 +, adq wrote: > On 20 November 2010 00:41, Nicholas A. Bellinger wrote: > > On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: > >> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: > >> > > >> > aio_ioctl is emulated anyway and currently bro

Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-19 Thread adq
On 20 November 2010 00:41, Nicholas A. Bellinger wrote: > On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: >> On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: >> > >> > aio_ioctl is emulated anyway and currently broken. >> >> What's broken about it currently? > > Mm,

Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-19 Thread Nicholas A. Bellinger
On Fri, 2010-11-19 at 19:39 +0100, Christoph Hellwig wrote: > On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: > > > > aio_ioctl is emulated anyway and currently broken. > > What's broken about it currently? Mm, I do not recall this being broken in the first place..? There w

Re: [Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-19 Thread Christoph Hellwig
On Thu, Nov 18, 2010 at 03:47:36PM +0100, Hannes Reinecke wrote: > > aio_ioctl is emulated anyway and currently broken. What's broken about it currently? > So better use 'normal' ioctl here as there are no benefits > on using the emulated async I/O call. There are huge benefits. Without it the

[Qemu-devel] [PATCH 12/16] scsi-generic: use plain ioctl

2010-11-18 Thread Hannes Reinecke
aio_ioctl is emulated anyway and currently broken. So better use 'normal' ioctl here as there are no benefits on using the emulated async I/O call. Signed-off-by: Hannes Reinecke --- hw/scsi-generic.c | 21 +++-- 1 files changed, 7 insertions(+), 14 deletions(-) diff --git a/