Re: [Qemu-devel] [PATCH 12/16] convert net_init_socket() to NetClientOptions

2012-06-05 Thread Paolo Bonzini
Il 05/06/2012 23:14, Eric Blake ha scritto: > On 06/05/2012 03:02 PM, Paolo Bonzini wrote: >> Il 22/05/2012 12:45, Laszlo Ersek ha scritto: >>> +if (sock->has_fd + sock->has_listen + sock->has_connect + >>> sock->has_mcast + >>> +sock->has_udp != 1) { >> >> Please add a cast, this does

Re: [Qemu-devel] [PATCH 12/16] convert net_init_socket() to NetClientOptions

2012-06-05 Thread Eric Blake
On 06/05/2012 03:02 PM, Paolo Bonzini wrote: > Il 22/05/2012 12:45, Laszlo Ersek ha scritto: >> +if (sock->has_fd + sock->has_listen + sock->has_connect + >> sock->has_mcast + >> +sock->has_udp != 1) { > > Please add a cast, this doesn't work with C99 bool. Huh? Where does C99 state

Re: [Qemu-devel] [PATCH 12/16] convert net_init_socket() to NetClientOptions

2012-06-05 Thread Paolo Bonzini
Il 22/05/2012 12:45, Laszlo Ersek ha scritto: > +if (sock->has_fd + sock->has_listen + sock->has_connect + > sock->has_mcast + > +sock->has_udp != 1) { Please add a cast, this doesn't work with C99 bool. Paolo > +error_report("exactly one of fd=, listen=, connect=, mcast= or

[Qemu-devel] [PATCH 12/16] convert net_init_socket() to NetClientOptions

2012-05-22 Thread Laszlo Ersek
I "reverse engineered" the following permissions between the -socket sub-options: fd listen connect mcast udp | localaddr fd x . .. . | . listen . x .. . | . connect. . x. . | . mcast