Re: [Qemu-devel] [PATCH 12/13] cuda.c: fix T2 timer and enable its interrupt

2015-11-11 Thread Mark Cave-Ayland
On 11/11/15 06:52, David Gibson wrote: > On Wed, Nov 04, 2015 at 11:25:43PM +, Mark Cave-Ayland wrote: >> On 04/11/15 03:40, David Gibson wrote: >> >>> On Fri, Oct 23, 2015 at 02:56:37PM +0100, Mark Cave-Ayland wrote: Fix the counter loading logic and enable the T2 interrupt when the time

Re: [Qemu-devel] [PATCH 12/13] cuda.c: fix T2 timer and enable its interrupt

2015-11-10 Thread David Gibson
On Wed, Nov 04, 2015 at 11:25:43PM +, Mark Cave-Ayland wrote: > On 04/11/15 03:40, David Gibson wrote: > > > On Fri, Oct 23, 2015 at 02:56:37PM +0100, Mark Cave-Ayland wrote: > >> Fix the counter loading logic and enable the T2 interrupt when the timer > >> expires. > > > > A mention of what

Re: [Qemu-devel] [PATCH 12/13] cuda.c: fix T2 timer and enable its interrupt

2015-11-04 Thread Mark Cave-Ayland
On 04/11/15 03:40, David Gibson wrote: > On Fri, Oct 23, 2015 at 02:56:37PM +0100, Mark Cave-Ayland wrote: >> Fix the counter loading logic and enable the T2 interrupt when the timer >> expires. > > A mention of what uses T2, and therefore why this is useful would be > good. There is a good chan

Re: [Qemu-devel] [PATCH 12/13] cuda.c: fix T2 timer and enable its interrupt

2015-11-03 Thread David Gibson
On Fri, Oct 23, 2015 at 02:56:37PM +0100, Mark Cave-Ayland wrote: > Fix the counter loading logic and enable the T2 interrupt when the timer > expires. A mention of what uses T2, and therefore why this is useful would be good. > > Signed-off-by: Mark Cave-Ayland > --- > hw/misc/macio/cuda.c |

[Qemu-devel] [PATCH 12/13] cuda.c: fix T2 timer and enable its interrupt

2015-10-23 Thread Mark Cave-Ayland
Fix the counter loading logic and enable the T2 interrupt when the timer expires. Signed-off-by: Mark Cave-Ayland --- hw/misc/macio/cuda.c | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/hw/misc/macio/cuda.c b/hw/misc/macio/cuda.c index 687cb