Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()

2010-06-23 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 23 Jun 2010 17:23:54 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: [...] >> > +qerror_report(QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER, >> > arg_name); >> >> Identifier's a bit on the long side, isn't it? > > Yes, suggestions? What

Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()

2010-06-23 Thread Luiz Capitulino
On Wed, 23 Jun 2010 17:23:54 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > This is similar to qmp_check_client_args(), but it checks if > > the input object follows the specification (QMP/qmp-spec.txt > > section 2.3). > > > > As we're limited to three keys, the work here is qu

Re: [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()

2010-06-23 Thread Markus Armbruster
Luiz Capitulino writes: > This is similar to qmp_check_client_args(), but it checks if > the input object follows the specification (QMP/qmp-spec.txt > section 2.3). > > As we're limited to three keys, the work here is quite simple: > we iterate over the input object, checking each time if the >

[Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj()

2010-06-22 Thread Luiz Capitulino
This is similar to qmp_check_client_args(), but it checks if the input object follows the specification (QMP/qmp-spec.txt section 2.3). As we're limited to three keys, the work here is quite simple: we iterate over the input object, checking each time if the current argument complies to the specif