Re: [Qemu-devel] [PATCH 11/60] AArch64: Add STP instruction emulation

2013-09-27 Thread Richard Henderson
On 09/26/2013 05:48 PM, Alexander Graf wrote: > +static int get_reg(uint32_t inst) > +{ > +return get_bits(inst, 0, 5); > +} Surely get_rt or some such related to the actual field name, not something so generic as "reg" which applies equally to any of several fields. > +static void ldst_do_ve

[Qemu-devel] [PATCH 11/60] AArch64: Add STP instruction emulation

2013-09-26 Thread Alexander Graf
This patch adds support for the STP instruction. It spans pretty much all store possibilities, so the patch also adds handling for load/store of integer as well as vector registers. Signed-off-by: Alexander Graf --- target-arm/translate-a64.c | 263 +