Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-06 Thread Paolo Bonzini
Il 05/06/2013 06:32, Michael S. Tsirkin ha scritto: > On Wed, Jun 05, 2013 at 09:48:19AM +0200, Paolo Bonzini wrote: >> Il 05/06/2013 06:53, Michael S. Tsirkin ha scritto: >>> On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: >>>

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 09:48:19AM +0200, Paolo Bonzini wrote: > Il 05/06/2013 06:53, Michael S. Tsirkin ha scritto: > > On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: > >> Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: > > +if (dev->msix_table || dev->msix_pba || dev->

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-05 Thread Paolo Bonzini
Il 05/06/2013 06:53, Michael S. Tsirkin ha scritto: > On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: >> Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: > +if (dev->msix_table || dev->msix_pba || dev->msix_entry_used) { > +msix_free(dev); > +} > +

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 12:40:00AM +0200, Paolo Bonzini wrote: > Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: > >> > +if (dev->msix_table || dev->msix_pba || dev->msix_entry_used) { > >> > +msix_free(dev); > >> > +} > >> > + > >> > dev->msix_table = g_malloc0(table_size)

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Paolo Bonzini
Il 05/06/2013 00:03, Michael S. Tsirkin ha scritto: >> > +if (dev->msix_table || dev->msix_pba || dev->msix_entry_used) { >> > +msix_free(dev); >> > +} >> > + >> > dev->msix_table = g_malloc0(table_size); >> > dev->msix_pba = g_malloc0(pba_size); >> > dev->msix_entry_

Re: [Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Michael S. Tsirkin
On Tue, Jun 04, 2013 at 08:52:06PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Please add a commit log with a bit more detail and documenting the motivation for change. > --- > hw/misc/vfio.c | 1 + > hw/net/vmxnet3.c | 3 +++ > hw/pci/msix.c | 26 +++

[Qemu-devel] [PATCH 11/39] msix: split msix_free from msix_uninit

2013-06-04 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/misc/vfio.c | 1 + hw/net/vmxnet3.c | 3 +++ hw/pci/msix.c | 26 -- hw/virtio/virtio-pci.c | 1 + include/hw/pci/msix.h | 1 + 5 files changed, 26 insertions(+), 6 deletions(-) diff --git a/hw/misc/vfio.c b/h