Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-05 Thread Michael S. Tsirkin
On Wed, May 04, 2016 at 08:44:37PM -0700, Yuanhan Liu wrote: > Hello, > > On Wed, May 04, 2016 at 10:13:49PM +0300, Michael S. Tsirkin wrote: > > How do you avoid it? > > > > > > Management is required to make this robust, auto-reconnect > > > > is handy for people bypassing management. > > > >

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-04 Thread Yuanhan Liu
Hello, On Wed, May 04, 2016 at 10:13:49PM +0300, Michael S. Tsirkin wrote: > How do you avoid it? > > > > Management is required to make this robust, auto-reconnect > > > is handy for people bypassing management. > > > > tbh, I don't like autoreconnect. My previous series didn't include > > this

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-04 Thread Michael S. Tsirkin
On Wed, May 04, 2016 at 03:16:44PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, May 2, 2016 at 2:04 PM, Michael S. Tsirkin wrote: > > On Mon, May 02, 2016 at 01:29:18PM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Mon, May 2, 2016 at 12:45 PM, Michael S. Tsirkin > >> wrote: > >> > 1

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-04 Thread Marc-André Lureau
Hi On Mon, May 2, 2016 at 2:04 PM, Michael S. Tsirkin wrote: > On Mon, May 02, 2016 at 01:29:18PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Mon, May 2, 2016 at 12:45 PM, Michael S. Tsirkin wrote: >> > 1. Graceful disconnect >> > - One should be able to do vmstop, disconnect, connect then vm

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-02 Thread Yuanhan Liu
On Mon, May 02, 2016 at 03:04:30PM +0300, Michael S. Tsirkin wrote: > On Mon, May 02, 2016 at 01:29:18PM +0200, Marc-André Lureau wrote: > > Hi > > > > On Mon, May 2, 2016 at 12:45 PM, Michael S. Tsirkin wrote: > > > 1. Graceful disconnect > > > - One should be able to do vmstop, disconnect, conn

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-02 Thread Yuanhan Liu
On Mon, May 02, 2016 at 01:45:31PM +0300, Michael S. Tsirkin wrote: > On Sun, May 01, 2016 at 02:04:42PM -0700, Yuanhan Liu wrote: > > On Sun, May 01, 2016 at 02:37:19PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Apr 29, 2016 at 10:48:35AM -0700, Yuanhan Liu wrote: > > > > > But, I > > > > > wo

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-02 Thread Michael S. Tsirkin
On Mon, May 02, 2016 at 01:29:18PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, May 2, 2016 at 12:45 PM, Michael S. Tsirkin wrote: > > 1. Graceful disconnect > > - One should be able to do vmstop, disconnect, connect then vm start > > This looks like a nice intermediate step. > > - Why woul

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-02 Thread Marc-André Lureau
Hi On Mon, May 2, 2016 at 12:45 PM, Michael S. Tsirkin wrote: > 1. Graceful disconnect > - One should be able to do vmstop, disconnect, connect then vm start > This looks like a nice intermediate step. > - Why would we always assume it's always remote initiating the disconnect? > Monitor comm

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-02 Thread Michael S. Tsirkin
On Sun, May 01, 2016 at 02:04:42PM -0700, Yuanhan Liu wrote: > On Sun, May 01, 2016 at 02:37:19PM +0300, Michael S. Tsirkin wrote: > > On Fri, Apr 29, 2016 at 10:48:35AM -0700, Yuanhan Liu wrote: > > > > But, I > > > > would worry first about a backend that crashes that it may corrupt the > > > > V

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-01 Thread Yuanhan Liu
On Sun, May 01, 2016 at 02:37:19PM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 29, 2016 at 10:48:35AM -0700, Yuanhan Liu wrote: > > > But, I > > > would worry first about a backend that crashes that it may corrupt the > > > VM memory too... > > > > Not quite sure I follow this. But, backend jus

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-05-01 Thread Michael S. Tsirkin
On Fri, Apr 29, 2016 at 10:48:35AM -0700, Yuanhan Liu wrote: > > But, I > > would worry first about a backend that crashes that it may corrupt the > > VM memory too... > > Not quite sure I follow this. But, backend just touches the virtio > related memory, so it will do no harm to the VM? It cras

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-29 Thread Yuanhan Liu
On Fri, Apr 29, 2016 at 12:40:09PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Apr 28, 2016 at 7:23 AM, Yuanhan Liu > wrote: > > On Fri, Apr 01, 2016 at 01:16:21PM +0200, marcandre.lur...@redhat.com wrote: > >> From: Marc-André Lureau > >> +Slave message types > >> +--- > >>

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-29 Thread Marc-André Lureau
Hi On Thu, Apr 28, 2016 at 7:23 AM, Yuanhan Liu wrote: > On Fri, Apr 01, 2016 at 01:16:21PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Signed-off-by: Marc-André Lureau >> --- >> docs/specs/vhost-user.txt | 15 +++ >> hw/virtio/vhost-user.c| 16 ++

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-27 Thread Yuanhan Liu
On Fri, Apr 01, 2016 at 01:16:21PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > docs/specs/vhost-user.txt | 15 +++ > hw/virtio/vhost-user.c| 16 > 2 files changed, 31 insertions(+) > > diff --

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-13 Thread Yuanhan Liu
On Wed, Apr 13, 2016 at 11:43:56PM +0200, Marc-André Lureau wrote: > On Wed, Apr 13, 2016 at 7:32 PM, Yuanhan Liu > wrote: > >> > >> > I'm asking because I found a seg fault issue sometimes, > >> > due to opaque is NULL. > > > > Oh, I was wrong, it's u being NULL, but not opaque. > >> > > >> > >>

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-13 Thread Marc-André Lureau
On Wed, Apr 13, 2016 at 7:32 PM, Yuanhan Liu wrote: >> >> > I'm asking because I found a seg fault issue sometimes, >> > due to opaque is NULL. > > Oh, I was wrong, it's u being NULL, but not opaque. >> > >> >> I would be interested to see the backtrace or have a reproducer. > > It's a normal test

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-13 Thread Yuanhan Liu
On Wed, Apr 13, 2016 at 05:51:15AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > Hi Marc, > > > > First of all, sorry again for late response! > > > > Last time I tried with your first version, I found few issues related > > with reconnect, mainly on the acked_feautre

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-13 Thread Marc-André Lureau
Hi - Original Message - > Hi Marc, > > First of all, sorry again for late response! > > Last time I tried with your first version, I found few issues related > with reconnect, mainly on the acked_feautres lost. While checking your > new code, I found that you've already solved that, whic

Re: [Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-12 Thread Yuanhan Liu
Hi Marc, First of all, sorry again for late response! Last time I tried with your first version, I found few issues related with reconnect, mainly on the acked_feautres lost. While checking your new code, I found that you've already solved that, which is great. So, I tried harder this time, your

[Qemu-devel] [PATCH 11/18] vhost-user: add shutdown support

2016-04-01 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- docs/specs/vhost-user.txt | 15 +++ hw/virtio/vhost-user.c| 16 2 files changed, 31 insertions(+) diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt index 8a635fa..60d6d13 100644 --- a