Re: [Qemu-devel] [PATCH 11/17] aio: make AioContexts GSources

2012-09-25 Thread Paolo Bonzini
Il 26/09/2012 00:06, Anthony Liguori ha scritto: >> > if (node) { >> > +g_source_remove_poll(&ctx->source, &node->pfd); >> > + > Why remove vs. setting events = 0? Because otherwise you'd get a dangling pointer to node->pfd. :) Paolo > add_poll/remove_poll also comes with an

Re: [Qemu-devel] [PATCH 11/17] aio: make AioContexts GSources

2012-09-25 Thread Anthony Liguori
Paolo Bonzini writes: > This lets AioContexts be used (optionally) with a glib main loop. > > Signed-off-by: Paolo Bonzini > --- > aio-posix.c | 4 > aio-win32.c | 4 > async.c | 65 > - > qemu-aio.h | 23

[Qemu-devel] [PATCH 11/17] aio: make AioContexts GSources

2012-09-25 Thread Paolo Bonzini
This lets AioContexts be used (optionally) with a glib main loop. Signed-off-by: Paolo Bonzini --- aio-posix.c | 4 aio-win32.c | 4 async.c | 65 - qemu-aio.h | 23 ++ 4 file modificati, 95 inserzio