Re: [Qemu-devel] [PATCH 11/15] target-i386: Add property getter for CPU model-id

2012-04-19 Thread Michael Roth
On Thu, Apr 19, 2012 at 06:47:57PM -0600, Eric Blake wrote: > On 04/19/2012 06:41 PM, Michael Roth wrote: > > >> +char *value; > >> +int i; > >> + > >> +value = g_malloc(48 + 1); > >> +for (i = 0; i < 48; i++) { > >> +value[i] = env->cpuid_model[i >> 2] >> (8 * (i & 3)); >

Re: [Qemu-devel] [PATCH 11/15] target-i386: Add property getter for CPU model-id

2012-04-19 Thread Eric Blake
On 04/19/2012 06:41 PM, Michael Roth wrote: >> +char *value; >> +int i; >> + >> +value = g_malloc(48 + 1); >> +for (i = 0; i < 48; i++) { >> +value[i] = env->cpuid_model[i >> 2] >> (8 * (i & 3)); > > setter code is a bit difficult to parse but I think we need value[i] &= 0

Re: [Qemu-devel] [PATCH 11/15] target-i386: Add property getter for CPU model-id

2012-04-19 Thread Michael Roth
On Wed, Apr 18, 2012 at 01:11:15AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > target-i386/cpu.c | 17 - > 1 files changed, 16 insertions(+), 1 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index 0c98fcc..cc4f566 100644 > --- a/t

[Qemu-devel] [PATCH 11/15] target-i386: Add property getter for CPU model-id

2012-04-17 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-i386/cpu.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 0c98fcc..cc4f566 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -711,6 +711,21 @@ static void x86_cp