Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2019-02-28 Thread Cornelia Huck
On Thu, 28 Feb 2019 10:59:13 -0500 "Jason J. Herne" wrote: > On 2/4/19 6:41 AM, Cornelia Huck wrote: > >> @@ -148,6 +370,9 @@ int do_cio(SubChannelId schid, uint32_t ccw_addr, int > >> fmt) > >> continue; > >> } > >> > >> +print_irb_err(&irb); > >> +ba

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2019-02-28 Thread Jason J. Herne
On 2/4/19 6:41 AM, Cornelia Huck wrote: ... +static void print_irb_err(Irb *irb) +{ +Ccw0 *this_ccw = u32toptr(irb->scsw.cpa); +Ccw0 *prev_ccw = u32toptr(irb->scsw.cpa - 8); I don't think you can cast this conditionally to format 0 -- I'd pass in the format from do_cio and handle it a

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2019-02-04 Thread Cornelia Huck
On Tue, 29 Jan 2019 08:29:18 -0500 "Jason J. Herne" wrote: > Add verbose error output for when unexpected i/o errors happen. This eases the > burden of debugging and reporting i/o errors. No error information is printed > in the success case, here is an example of what is output on error: > > vf

[Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2019-01-29 Thread Jason J. Herne
Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: vfio-ccw device I/O error - Interrupt Response Block Data: Function C

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2018-12-13 Thread Cornelia Huck
On Wed, 12 Dec 2018 09:11:14 -0500 "Jason J. Herne" wrote: > Add verbose error output for when unexpected i/o errors happen. This eases the > burden of debugging and reporting i/o errors. No error information is printed > in the success case, here is an example of what is output on error: > > vf

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: vfio-ccw device I/O er

[Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2018-12-12 Thread Jason J. Herne
Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: vfio-ccw device I/O error - Interrupt Response Block Data: Function C