Re: [Qemu-devel] [PATCH 11/14] virtio-net: fix used len for tx

2012-09-25 Thread Michael S. Tsirkin
On Tue, Sep 25, 2012 at 02:15:07PM +0800, Jason Wang wrote: > On 09/25/2012 07:05 AM, Michael S. Tsirkin wrote: > >There is no out sg for TX, so used buf length for tx > >should always be 0. > > According to the spec, the len is "Total length of the descriptor > chain which was used (written to)".

Re: [Qemu-devel] [PATCH 11/14] virtio-net: fix used len for tx

2012-09-24 Thread Jason Wang
On 09/25/2012 07:05 AM, Michael S. Tsirkin wrote: There is no out sg for TX, so used buf length for tx should always be 0. According to the spec, the len is "Total length of the descriptor chain which was used (written to)". So I wonder if we need to pass the len here, it looks useful for gue

[Qemu-devel] [PATCH 11/14] virtio-net: fix used len for tx

2012-09-24 Thread Michael S. Tsirkin
There is no out sg for TX, so used buf length for tx should always be 0. Signed-off-by: Michael S. Tsirkin --- hw/virtio-net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 2381ee5..d9a9f8f 100644 --- a/hw/virtio-net.c +++ b/hw/vi