Re: [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async

2018-02-28 Thread Peter Xu
On Wed, Feb 28, 2018 at 09:20:47AM +, Daniel P. Berrangé wrote: > On Wed, Feb 28, 2018 at 01:06:30PM +0800, Peter Xu wrote: > > Let qio_channel_socket_connect_async() return the created QIOTask object > > for the async connection. In tcp chardev, cache that in SocketChardev > > for further use

Re: [Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async

2018-02-28 Thread Daniel P . Berrangé
On Wed, Feb 28, 2018 at 01:06:30PM +0800, Peter Xu wrote: > Let qio_channel_socket_connect_async() return the created QIOTask object > for the async connection. In tcp chardev, cache that in SocketChardev > for further use. With the QIOTask refcount, this is pretty safe. Why do you want to retur

[Qemu-devel] [PATCH 11/14] qio/chardev: return QIOTask when connect async

2018-02-27 Thread Peter Xu
Let qio_channel_socket_connect_async() return the created QIOTask object for the async connection. In tcp chardev, cache that in SocketChardev for further use. With the QIOTask refcount, this is pretty safe. Since at it, generalize out tcp_chr_socket_connect_async() since the logic is used in bo