Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-26 Thread Eric Blake
On 03/26/2013 07:43 AM, Igor Mammedov wrote: >>> The alternative is to have cpu-set-online and later cpu-set-offline. Quite >>> verbose, but doesn't have issues. > It looks like better as way to go. Later on we could keep them for > compatibility sake and map it to device_add/device_del commands w

Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-26 Thread Luiz Capitulino
On Tue, 26 Mar 2013 14:43:01 +0100 Igor Mammedov wrote: > On Mon, 25 Mar 2013 14:22:36 -0600 > Eric Blake wrote: > > > On 03/25/2013 02:09 PM, Luiz Capitulino wrote: > > > On Mon, 25 Mar 2013 16:35:11 +0100 > > > Igor Mammedov wrote: > > > > > > > >> +void qmp_cpu_set(int64_t id, const bool

Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-26 Thread Igor Mammedov
On Mon, 25 Mar 2013 14:22:36 -0600 Eric Blake wrote: > On 03/25/2013 02:09 PM, Luiz Capitulino wrote: > > On Mon, 25 Mar 2013 16:35:11 +0100 > > Igor Mammedov wrote: > > > > >> +void qmp_cpu_set(int64_t id, const bool online, Error **errp) > >> +{ > >> +if (online) { > >> +do_cpu_h

Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-25 Thread Luiz Capitulino
On Mon, 25 Mar 2013 16:35:11 +0100 Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > v2: > * s/cpu_set/cpu-set/ > * qmp doc style fix > * use bool type instead of opencodding online/offline string > suggested-by: Eric Blake > changes are on WIP branch: https://github.com/

Re: [Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-25 Thread Eric Blake
On 03/25/2013 02:09 PM, Luiz Capitulino wrote: > On Mon, 25 Mar 2013 16:35:11 +0100 > Igor Mammedov wrote: > >> +void qmp_cpu_set(int64_t id, const bool online, Error **errp) >> +{ >> +if (online) { >> +do_cpu_hot_add(id, errp); >> +} else { >> +error_setg(errp, "Unplug i

[Qemu-devel] [PATCH 11/12 v2] qmp: add cpu-set qmp command

2013-03-25 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- v2: * s/cpu_set/cpu-set/ * qmp doc style fix * use bool type instead of opencodding online/offline string suggested-by: Eric Blake changes are on WIP branch: https://github.com/imammedo/qemu/tree/cpu_set.WIP --- include/sysemu/sysemu.h |2 ++ qa