Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-22 Thread Eduardo Habkost
On Mon, Oct 22, 2012 at 02:36:01PM +0200, Igor Mammedov wrote: > On Tue, 16 Oct 2012 16:08:42 -0300 > Eduardo Habkost wrote: > [...] > > diff --git a/qom/qdev-properties.c b/qom/qdev-properties.c > > new file mode 100644 > > index 000..2e82cb9 > > --- /dev/null > > +++ b/qom/qdev-properties.c

Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-22 Thread Igor Mammedov
On Tue, 16 Oct 2012 16:08:42 -0300 Eduardo Habkost wrote: [...] > diff --git a/qom/qdev-properties.c b/qom/qdev-properties.c > new file mode 100644 > index 000..2e82cb9 > --- /dev/null > +++ b/qom/qdev-properties.c [...] > +void qdev_prop_set_globals(DeviceState *dev) > +{ > +ObjectClass *

Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-19 Thread Eduardo Habkost
On Wed, Oct 17, 2012 at 08:21:17PM +0100, Peter Maydell wrote: > On 17 October 2012 19:11, Anthony Liguori wrote: > > It's dangerously close to bike-shedding, but i don't think qdev belongs > > in qom/. It's not core infrastructure. It's the device base class and > > belongs IMHO in hw/. > > "-

Re: [Qemu-devel] [PATCH 11/12] include core qdev code into *-user, too

2012-10-17 Thread Peter Maydell
On 17 October 2012 19:11, Anthony Liguori wrote: > It's dangerously close to bike-shedding, but i don't think qdev belongs > in qom/. It's not core infrastructure. It's the device base class and > belongs IMHO in hw/. "-user emulators don't get anything from hw/" is one of those semi arbitrary