Re: [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where needed

2015-06-15 Thread Eric Blake
On 06/13/2015 08:20 AM, Markus Armbruster wrote: > In particular, don't include it into headers. > > Signed-off-by: Markus Armbruster > --- > 29 files changed, 4 insertions(+), 29 deletions(-) Again, it might be nice to call out in the commit message how you determined which files could drop i

Re: [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where needed

2015-06-15 Thread Stefan Hajnoczi
On Sat, Jun 13, 2015 at 04:20:58PM +0200, Markus Armbruster wrote: > In particular, don't include it into headers. > > Signed-off-by: Markus Armbruster > --- > balloon.c | 2 +- > blockdev-nbd.c| 1 - > hw/core/platform-bus.c| 1 - > hw/display/qxl.c

[Qemu-devel] [PATCH 11/11] Include monitor/monitor.h exactly where needed

2015-06-13 Thread Markus Armbruster
In particular, don't include it into headers. Signed-off-by: Markus Armbruster --- balloon.c | 2 +- blockdev-nbd.c| 1 - hw/core/platform-bus.c| 1 - hw/display/qxl.c | 1 - hw/i386/pc.c | 1 - hw/ide/ahci.c