Re: [Qemu-devel] [PATCH 10/19] qapi: Fix broken discriminator error messages

2019-09-17 Thread Eric Blake
On 9/14/19 10:34 AM, Markus Armbruster wrote: > check_union() checks the discriminator exists in base and makes sense. > Two error messages mention the base. These are broken for anonymous > bases, as demonstrated by tests flat-union-invalid-discriminator and > flat-union-invalid-if-discriminator.

[Qemu-devel] [PATCH 10/19] qapi: Fix broken discriminator error messages

2019-09-14 Thread Markus Armbruster
check_union() checks the discriminator exists in base and makes sense. Two error messages mention the base. These are broken for anonymous bases, as demonstrated by tests flat-union-invalid-discriminator and flat-union-invalid-if-discriminator.err. The third one doesn't bother. First broken when