Re: [Qemu-devel] [PATCH 10/19] libqos/ahci: Add ide cmd properties

2015-02-02 Thread Paolo Bonzini
On 30/01/2015 19:42, John Snow wrote: > The "Invalid Command Sentinel" here that caps the property array is an > invalid ATA command, namely 0x01. 0x00 is NOP and 0xFF is reserved for > vendor usage, so I chose the first invalid one instead. You can use ARRAY_SIZE instead. Paolo

[Qemu-devel] [PATCH 10/19] libqos/ahci: Add ide cmd properties

2015-01-30 Thread John Snow
Add a structure that defines some properties of various IDE commands. These will be used to simplify the interface to the libqos AHCI calls, lessening the redundancy of specifying and respecifying properties of commands to various helper functions. The "Invalid Command Sentinel" here that caps the