Re: [Qemu-devel] [PATCH 10/18] target/mips: convert to TranslatorOps

2018-04-22 Thread Richard Henderson
On 04/20/2018 08:55 AM, Emilio G. Cota wrote: > - Added an assert in translate_insn, before exiting due to an exception, > to make sure that is_jmp is set to DISAS_EXCP (the exception generation > function always sets it.) Comment is out of date -- s/EXCP/NORETURN/. r~

[Qemu-devel] [PATCH 10/18] target/mips: convert to TranslatorOps

2018-04-20 Thread Emilio G. Cota
Notes: - DISAS_TOO_MANY replaces the former "break" in the translation loop. However, care must be taken not to overwrite a previous condition in is_jmp; that's why in translate_insn we first check is_jmp and return if it's != DISAS_NEXT. - Added an assert in translate_insn, before exiting