Re: [Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-09 Thread Edgar E. Iglesias
On Thu, Apr 09, 2015 at 03:14:58PM +0100, Peter Maydell wrote: > On 9 April 2015 at 12:23, Edgar E. Iglesias wrote: > > On Tue, Apr 07, 2015 at 09:09:56PM +0100, Peter Maydell wrote: > >> > >> +if (regime_is_secure(env, mmu_idx)) { > >> +/* The page table entries may downgrade this to

Re: [Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 12:23, Edgar E. Iglesias wrote: > On Tue, Apr 07, 2015 at 09:09:56PM +0100, Peter Maydell wrote: >> >> +if (regime_is_secure(env, mmu_idx)) { >> +/* The page table entries may downgrade this to non-secure, but >> + * cannot upgrade an non-secure translation r

Re: [Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:56PM +0100, Peter Maydell wrote: > Honour the NS bit in ARM page tables: > * when adding entries to the TLB, include the Secure/NonSecure >transaction attribute > * set the NS bit in the PAR when doing ATS operations > > Note that we don't yet correctly use the

[Qemu-devel] [PATCH 10/14] target-arm: Honour NS bits in page tables

2015-04-07 Thread Peter Maydell
Honour the NS bit in ARM page tables: * when adding entries to the TLB, include the Secure/NonSecure transaction attribute * set the NS bit in the PAR when doing ATS operations Note that we don't yet correctly use the NSTable bit to cause the page table walk itself to use the right attributes