Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-09-02 Thread Anthony Liguori
On 08/25/2011 08:33 AM, Luiz Capitulino wrote: On Wed, 24 Aug 2011 13:43:05 -0500 Anthony Liguori wrote: This is a new QMP only command that only changes the VNC password. Isn't this useful in HMP too? I think the right design goal for HMP is to minimize the number of commands since a hum

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-25 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:43:05 -0500 Anthony Liguori wrote: > This is a new QMP only command that only changes the VNC password. Isn't this useful in HMP too? > > Signed-off-by: Anthony Liguori > --- > qapi-schema.json | 13 + > qmp-commands.hx |8 > qmp.c

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-25 Thread Anthony Liguori
On 08/25/2011 04:07 AM, Gerd Hoffmann wrote: On 08/24/11 20:43, Anthony Liguori wrote: This is a new QMP only command that only changes the VNC password. What is wrong with "set_password vnc $secret" ? Overloading a single function to do multiple things makes the function hard to use. Con

Re: [Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-25 Thread Gerd Hoffmann
On 08/24/11 20:43, Anthony Liguori wrote: This is a new QMP only command that only changes the VNC password. What is wrong with "set_password vnc $secret" ? cheers, Gerd

[Qemu-devel] [PATCH 10/14] qapi: add change-vnc-password

2011-08-24 Thread Anthony Liguori
This is a new QMP only command that only changes the VNC password. Signed-off-by: Anthony Liguori --- qapi-schema.json | 13 + qmp-commands.hx |8 qmp.c| 11 ++- 3 files changed, 31 insertions(+), 1 deletions(-) diff --git a/qapi-schema.json b/q