Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-22 Thread Laurent Desnogues
Hi Richard, On Fri, Feb 20, 2015 at 4:53 PM, Richard Henderson wrote: > On 02/20/2015 05:57 AM, Laurent Desnogues wrote: >> The problem with this approach is that you'll always call the FP >> compare which might result in FP flags corruption. >> >> The ARMv8 manual clearly states that the FP comp

Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-20 Thread Richard Henderson
On 02/20/2015 05:57 AM, Laurent Desnogues wrote: > The problem with this approach is that you'll always call the FP > compare which might result in FP flags corruption. > > The ARMv8 manual clearly states that the FP compare should only be > called if the condition holds. Ah, I hadn't considered

Re: [Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-20 Thread Laurent Desnogues
Hi Richard, On Thu, Feb 19, 2015 at 10:14 PM, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target-arm/translate-a64.c | 50 > +++--- > 1 file changed, 29 insertions(+), 21 deletions(-) > > diff --git a/target-arm/translate-a64.c b/

[Qemu-devel] [PATCH 10/11] target-arm: Implement fccmp branchless

2015-02-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/translate-a64.c | 50 +++--- 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 8171a1f..5539ae3 100644 --- a/target-arm/translate-a64