Re: [Qemu-devel] [PATCH 10/11] block: let commit blockjob run in BDS AioContext

2014-10-07 Thread Max Reitz
On 06.10.2014 11:30, Stefan Hajnoczi wrote: On Sat, Oct 04, 2014 at 11:28:22PM +0200, Max Reitz wrote: On 01.10.2014 19:01, Stefan Hajnoczi wrote: The commit block job must run in the BlockDriverState AioContext so that it works with dataplane. Acquire the AioContext in blockdev.c so starting

Re: [Qemu-devel] [PATCH 10/11] block: let commit blockjob run in BDS AioContext

2014-10-06 Thread Stefan Hajnoczi
On Sat, Oct 04, 2014 at 11:28:22PM +0200, Max Reitz wrote: > On 01.10.2014 19:01, Stefan Hajnoczi wrote: > >The commit block job must run in the BlockDriverState AioContext so that > >it works with dataplane. > > > >Acquire the AioContext in blockdev.c so starting the block job is safe. > >One deta

Re: [Qemu-devel] [PATCH 10/11] block: let commit blockjob run in BDS AioContext

2014-10-04 Thread Max Reitz
On 01.10.2014 19:01, Stefan Hajnoczi wrote: The commit block job must run in the BlockDriverState AioContext so that it works with dataplane. Acquire the AioContext in blockdev.c so starting the block job is safe. One detail here is that the bdrv_drain_all() must be moved inside the aio_context_

[Qemu-devel] [PATCH 10/11] block: let commit blockjob run in BDS AioContext

2014-10-01 Thread Stefan Hajnoczi
The commit block job must run in the BlockDriverState AioContext so that it works with dataplane. Acquire the AioContext in blockdev.c so starting the block job is safe. One detail here is that the bdrv_drain_all() must be moved inside the aio_context_acquire() region so requests cannot sneak in b