Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed

2015-06-16 Thread Markus Armbruster
Eric Blake writes: > On 06/13/2015 08:20 AM, Markus Armbruster wrote: >> In particular, don't include it into headers. >> >> Signed-off-by: Markus Armbruster >> --- > >> 46 files changed, 25 insertions(+), 21 deletions(-) > > Assuming this was done by deleting from headers, then adding it into

Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed

2015-06-15 Thread Eric Blake
On 06/13/2015 08:20 AM, Markus Armbruster wrote: > In particular, don't include it into headers. > > Signed-off-by: Markus Armbruster > --- > 46 files changed, 25 insertions(+), 21 deletions(-) Assuming this was done by deleting from headers, then adding it into .c files that no longer compile

Re: [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed

2015-06-15 Thread Stefan Hajnoczi
On Sat, Jun 13, 2015 at 04:20:57PM +0200, Markus Armbruster wrote: > In particular, don't include it into headers. > > Signed-off-by: Markus Armbruster > --- > backends/hostmem.c | 1 - > balloon.c| 1 + > block.c | 1 + > block/backup.c

[Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed

2015-06-13 Thread Markus Armbruster
In particular, don't include it into headers. Signed-off-by: Markus Armbruster --- backends/hostmem.c | 1 - balloon.c| 1 + block.c | 1 + block/backup.c | 1 + block/commit.c | 1 + block/mirror.c | 1