Dear Eric,
Eric Blake writes:
> arglist = (all other parameters)
> if self.device_name:
> arglist.append(id=self.device_name)
> else:
> arglist.append(device='drive0')
> invoke(self.vm.qmp, arglist)
That would be:
qmp_args = {'cmd': 'blockdev-change-medium', 'filename': new_img
On 09/15/2016 11:28 AM, Sascha Silbe wrote:
> Dear Eric,
>
> Sascha Silbe writes:
>
>> result = self.vm.qmp('blockdev-change-medium',
>> id=self.device_name or 'drive0',
>> filename=new_img,
>> format=iotests.imgfmt)
>
> Sorry,
Dear Eric,
Sascha Silbe writes:
> result = self.vm.qmp('blockdev-change-medium',
> id=self.device_name or 'drive0',
> filename=new_img,
> format=iotests.imgfmt)
Sorry, my eyes deceived me. I thought the original code was setting
On 09/15/2016 11:16 AM, Sascha Silbe wrote:
>>> +if self.device_name is not None:
>>> +result = self.vm.qmp('blockdev-change-medium',
>>> + id=self.device_name, filename=new_img,
>>> + format=iotests.imgfmt)
>>> +
Dear Eric,
(replying only to the Python coding part, haven't looked at the patch
itself)
Eric Blake writes:
> On 08/19/2016 11:50 AM, Kevin Wolf wrote:
>> @@ -76,9 +79,15 @@ class GeneralChangeTestsBaseClass(ChangeBaseClass):
>> self.assert_qmp(result, 'return[0]/inserted/image/filenam
Am 15.09.2016 um 00:13 hat Eric Blake geschrieben:
> On 08/19/2016 11:50 AM, Kevin Wolf wrote:
> > We just added the option to use qdev device names in all device related
> > block QMP commands. This patch converts some of the test cases in 118 to
> > use qdev device names instead of BlockBackend n
On 08/19/2016 11:50 AM, Kevin Wolf wrote:
> We just added the option to use qdev device names in all device related
> block QMP commands. This patch converts some of the test cases in 118 to
> use qdev device names instead of BlockBackend names to cover the new
> way. It converts cases for each of
We just added the option to use qdev device names in all device related
block QMP commands. This patch converts some of the test cases in 118 to
use qdev device names instead of BlockBackend names to cover the new
way. It converts cases for each of the media change commands, but only
for CD-ROM and
