Re: [Qemu-devel] [PATCH 10/10] pc: parse cpu features only once

2016-06-09 Thread Eduardo Habkost
On Thu, Jun 09, 2016 at 02:07:35PM +0200, Igor Mammedov wrote: > On Wed, 8 Jun 2016 14:03:15 -0300 > Eduardo Habkost wrote: [...] > > > -cpu = pc_new_cpu(machine->cpu_model, apic_id, &local_err); > > > +assert(pcms->possible_cpus->cpus[0].cpu); /* BSP is always > > > present */ > > > +

Re: [Qemu-devel] [PATCH 10/10] pc: parse cpu features only once

2016-06-09 Thread Igor Mammedov
On Wed, 8 Jun 2016 14:03:15 -0300 Eduardo Habkost wrote: > On Mon, Jun 06, 2016 at 05:16:52PM +0200, Igor Mammedov wrote: > > considering that features are converted to > > global properties and global properties are > > automatically applied to every new instance > > of created CPU (at object_ne

Re: [Qemu-devel] [PATCH 10/10] pc: parse cpu features only once

2016-06-08 Thread Eduardo Habkost
On Mon, Jun 06, 2016 at 05:16:52PM +0200, Igor Mammedov wrote: > considering that features are converted to > global properties and global properties are > automatically applied to every new instance > of created CPU (at object_new() time), there > is no point in parsing cpu_model string every > ti

[Qemu-devel] [PATCH 10/10] pc: parse cpu features only once

2016-06-06 Thread Igor Mammedov
considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only