Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-05 Thread Eric Blake
On 03/05/2014 01:15 PM, Max Reitz wrote: >>> +\"filename\": \"$TEST_IMG\" >> Are we guaranteed that $TEST_IMG will not contain any " which would >> render this invalid JSON? > > Probably not, but do you have an idea to circumvent this? If nothing else, we can at least be paranoid wit

Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-05 Thread Max Reitz
On 05.03.2014 18:27, Eric Blake wrote: On 03/03/2014 08:28 AM, Max Reitz wrote: Add a test for the JSON protocol driver. Signed-off-by: Max Reitz --- tests/qemu-iotests/084 | 114 + + +# Taken from test 072 The comment is okay, but... +echo +

Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-05 Thread Eric Blake
On 03/03/2014 08:28 AM, Max Reitz wrote: > Add a test for the JSON protocol driver. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/084 | 114 > + > + > +# Taken from test 072 The comment is okay, but... > +echo > +echo "=== Testing nest

[Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol

2014-03-03 Thread Max Reitz
Add a test for the JSON protocol driver. Signed-off-by: Max Reitz --- tests/qemu-iotests/084 | 114 + tests/qemu-iotests/084.out | 39 tests/qemu-iotests/group | 1 + 3 files changed, 154 insertions(+) create mode 100755 test