Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:56, Kevin Wolf ha scritto: >> > Because in this case there is no format over it, so the topmost BDS will >> > be open with BDRV_O_CACHE_WB and no one will call bdrv_flush. > Doesn't block.c do it now? bs->enable_write_cache still wouldn't be set, > even if .bdrv_file_open() is call

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Kevin Wolf
Am 31.05.2012 13:43, schrieb Paolo Bonzini: > Il 31/05/2012 13:33, Kevin Wolf ha scritto: diff --git a/block.c b/block.c index 7add33c..43b3de6 100644 --- a/block.c +++ b/block.c @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, const char *filenam

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Paolo Bonzini
Il 31/05/2012 13:33, Kevin Wolf ha scritto: >> > diff --git a/block.c b/block.c >> > index 7add33c..43b3de6 100644 >> > --- a/block.c >> > +++ b/block.c >> > @@ -661,7 +661,7 @@ static int bdrv_open_common(BlockDriverState *bs, >> > const char *filename, >> > if (drv->bdrv_file_open) { >> >

Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-31 Thread Kevin Wolf
Am 22.05.2012 18:17, schrieb Paolo Bonzini: > Formats are entirely in charge of flushes for metadata writes. For > guest-initiated writes, a writethrough cache is faked in the block layer. > > Signed-off-by: Paolo Bonzini > --- > block.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

[Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode

2012-05-22 Thread Paolo Bonzini
Formats are entirely in charge of flushes for metadata writes. For guest-initiated writes, a writethrough cache is faked in the block layer. Signed-off-by: Paolo Bonzini --- block.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index 7add33c..43b3de