Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path

2011-11-18 Thread Paolo Bonzini
On 11/18/2011 03:10 PM, Kevin Wolf wrote: Whatever you think is best. I already included the other patch in the pull request, so any other change would have to be on top. Ok, I'll put together a formal patch today and test it with seabios. Paolo

Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path

2011-11-18 Thread Kevin Wolf
Am 18.11.2011 14:59, schrieb Paolo Bonzini: > On 11/18/2011 02:36 PM, Andreas Färber wrote: >> Am 18.11.2011 13:35, schrieb Kevin Wolf: >>> Am 15.11.2011 17:36, schrieb Paolo Bonzini: The pre-1.0 firmware path for SCSI devices already included the LUN using the suffix argument to add_boot

Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path

2011-11-18 Thread Paolo Bonzini
On 11/18/2011 02:36 PM, Andreas Färber wrote: Am 18.11.2011 13:35, schrieb Kevin Wolf: Am 15.11.2011 17:36, schrieb Paolo Bonzini: The pre-1.0 firmware path for SCSI devices already included the LUN using the suffix argument to add_boot_device_path. I missed that when making channel and LUN cu

Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path

2011-11-18 Thread Andreas Färber
Am 18.11.2011 13:35, schrieb Kevin Wolf: > Am 15.11.2011 17:36, schrieb Paolo Bonzini: >> The pre-1.0 firmware path for SCSI devices already included the LUN >> using the suffix argument to add_boot_device_path. I missed that when >> making channel and LUN customizable. Avoid that it is included

Re: [Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path

2011-11-18 Thread Kevin Wolf
Am 15.11.2011 17:36, schrieb Paolo Bonzini: > The pre-1.0 firmware path for SCSI devices already included the LUN > using the suffix argument to add_boot_device_path. I missed that when > making channel and LUN customizable. Avoid that it is included twice, and > convert the colons to commas for

[Qemu-devel] [PATCH 1.0 v2] scsi: fix fw path

2011-11-15 Thread Paolo Bonzini
The pre-1.0 firmware path for SCSI devices already included the LUN using the suffix argument to add_boot_device_path. I missed that when making channel and LUN customizable. Avoid that it is included twice, and convert the colons to commas for consistency with other kinds of devices Signed-off-