Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/02/2015 17:34, Markus Armbruster wrote: >> I've typed error_report("%s", error_get_pretty(ERR)) too many times >> already, and I've fixed too many instances of qerror_report_err(ERR) >> to error_report("%s", error_get_pretty(ERR)) as well. Capture the >> pattern in

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.02.2015 um 18:20 hat Eric Blake geschrieben: >> On 02/10/2015 09:34 AM, Markus Armbruster wrote: >> > I've typed error_report("%s", error_get_pretty(ERR)) too many times >> > already, and I've fixed too many instances of qerror_report_err(ERR) >> > to error_report("%s",

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Paolo Bonzini
On 10/02/2015 23:04, Eduardo Habkost wrote: > $ spatch --sp-file /tmp/error_report.spatch $(git grep -l error_report) > > /tmp/error_report.patch Does it work without specifying any include path? I tried this a while ago: @@ identifier s, fld; @@ struct s { ... - QEMUTimer *fld; + Q

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-11 Thread Kevin Wolf
Am 10.02.2015 um 18:20 hat Eric Blake geschrieben: > On 02/10/2015 09:34 AM, Markus Armbruster wrote: > > I've typed error_report("%s", error_get_pretty(ERR)) too many times > > already, and I've fixed too many instances of qerror_report_err(ERR) > > to error_report("%s", error_get_pretty(ERR)) as

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Eduardo Habkost
On Tue, Feb 10, 2015 at 05:44:59PM +0100, Paolo Bonzini wrote: > > > On 10/02/2015 17:34, Markus Armbruster wrote: > > I've typed error_report("%s", error_get_pretty(ERR)) too many times > > already, and I've fixed too many instances of qerror_report_err(ERR) > > to error_report("%s", error_get_p

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Eric Blake
On 02/10/2015 09:34 AM, Markus Armbruster wrote: > I've typed error_report("%s", error_get_pretty(ERR)) too many times > already, and I've fixed too many instances of qerror_report_err(ERR) > to error_report("%s", error_get_pretty(ERR)) as well. Capture the > pattern in a convenience function. >

Re: [Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Paolo Bonzini
On 10/02/2015 17:34, Markus Armbruster wrote: > I've typed error_report("%s", error_get_pretty(ERR)) too many times > already, and I've fixed too many instances of qerror_report_err(ERR) > to error_report("%s", error_get_pretty(ERR)) as well. Capture the > pattern in a convenience function. > >

[Qemu-devel] [PATCH 1/9] error: New convenience function error_report_err()

2015-02-10 Thread Markus Armbruster
I've typed error_report("%s", error_get_pretty(ERR)) too many times already, and I've fixed too many instances of qerror_report_err(ERR) to error_report("%s", error_get_pretty(ERR)) as well. Capture the pattern in a convenience function. Since it's almost invariably followed by error_free(), stuf