Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 05:42 PM, Gerd Hoffmann wrote: Hi, Rebased and re-rested (a bit), new version send. Added to the queue. I see you've just done a pull-req for what was in usb-next already, I really hope you can do another one with the status + length splitting patches in there, so that

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Gerd Hoffmann
Hi, > Rebased and re-rested (a bit), new version send. Added to the queue. > I see you've just done a pull-req for what was in usb-next already, > I really hope you can do another one with the status + length splitting > patches in there, so that those can go into 1.3, this will make it > a lo

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 03:23 PM, Gerd Hoffmann wrote: Hi, Here is a patch changing the way this is handled to something which hopefully will be more to your liking. Feel free to squash this into the original commit. Looks good but doesn't apply. Likewise the "split packet result into actual_l

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Gerd Hoffmann
Hi, > Here is a patch changing the way this is handled to something which > hopefully will be more to your liking. Feel free to squash this > into the original commit. Looks good but doesn't apply. Likewise the "split packet result into actual_length + status" patch series. Pushed current usb

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 11:08 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! + */ +if (state != leftover) { +g_free(c

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 02:14 PM, Hans de Goede wrote: Hi, On 11/01/2012 11:08 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! +

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Hans de Goede
Hi, On 11/01/2012 11:08 AM, Gerd Hoffmann wrote: On 10/31/12 13:47, Hans de Goede wrote: +/* + * If we had leftover packets the hcd driver will have cancelled them + * and usb_combined_packet_cancel has already freed combined! + */ +if (state != leftover) { +g_free(c

Re: [Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-11-01 Thread Gerd Hoffmann
On 10/31/12 13:47, Hans de Goede wrote: > +/* > + * If we had leftover packets the hcd driver will have cancelled them > + * and usb_combined_packet_cancel has already freed combined! > + */ > +if (state != leftover) { > +g_free(combined); > +} This calls for refere

[Qemu-devel] [PATCH 1/8] usb: Add packet combining functions

2012-10-31 Thread Hans de Goede
Currently we only do pipelining for output endpoints, since to properly support short-not-ok semantics we can only have one outstanding input packet. Since the ehci and uhci controllers have a limited per td packet size guests will split large input transfers to into multiple packets, and since we