Re: [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer

2015-09-24 Thread David Gibson
On Thu, Sep 24, 2015 at 10:01:55AM -0600, Alex Williamson wrote: > On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > > Currently the VFIOContainer iommu_data field contains a union with > > different information for different host iommu types. However: > >* It only actually contains inf

Re: [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer

2015-09-24 Thread Thomas Huth
On 24/09/15 06:33, David Gibson wrote: > Currently the VFIOContainer iommu_data field contains a union with > different information for different host iommu types. However: >* It only actually contains information for the x86-like "Type1" iommu >* Because we have a common listener the Type

Re: [Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer

2015-09-24 Thread Alex Williamson
On Thu, 2015-09-24 at 14:33 +1000, David Gibson wrote: > Currently the VFIOContainer iommu_data field contains a union with > different information for different host iommu types. However: >* It only actually contains information for the x86-like "Type1" iommu >* Because we have a common l

[Qemu-devel] [PATCH 1/7] vfio: Remove unneeded union from VFIOContainer

2015-09-23 Thread David Gibson
Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the Type1 fields are actually used on all IOMMU types,