Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-08 Thread Markus Armbruster
Stefan Weil writes: > Am 08.08.2016 um 08:33 schrieb Fam Zheng: >> On Mon, 08/08 08:30, Stefan Weil wrote: >>> Am 02.08.2016 um 11:18 schrieb Fam Zheng: >>> [...] +void qemu_uuid_generate(qemu_uuid_t out) +{ +/* Version 4 UUID, RFC4122 4.4. */ +QEMU_BUILD_BUG_ON(sizeof

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-08 Thread Stefan Weil
Am 08.08.2016 um 08:33 schrieb Fam Zheng: > On Mon, 08/08 08:30, Stefan Weil wrote: >> Am 02.08.2016 um 11:18 schrieb Fam Zheng: >> [...] >>> +void qemu_uuid_generate(qemu_uuid_t out) >>> +{ >>> +/* Version 4 UUID, RFC4122 4.4. */ >>> +QEMU_BUILD_BUG_ON(sizeof(qemu_uuid_t) != 16); >>> +

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-07 Thread Fam Zheng
On Mon, 08/08 08:30, Stefan Weil wrote: > Am 02.08.2016 um 11:18 schrieb Fam Zheng: > [...] > > +void qemu_uuid_generate(qemu_uuid_t out) > > +{ > > +/* Version 4 UUID, RFC4122 4.4. */ > > +QEMU_BUILD_BUG_ON(sizeof(qemu_uuid_t) != 16); > > +*((guint32 *)out + 0) = g_random_int(); > > +

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-07 Thread Stefan Weil
Am 02.08.2016 um 11:18 schrieb Fam Zheng: [...] > +void qemu_uuid_generate(qemu_uuid_t out) > +{ > +/* Version 4 UUID, RFC4122 4.4. */ > +QEMU_BUILD_BUG_ON(sizeof(qemu_uuid_t) != 16); > +*((guint32 *)out + 0) = g_random_int(); > +*((guint32 *)out + 1) = g_random_int(); > +*((gui

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-05 Thread Fam Zheng
On Thu, 08/04 16:48, Daniel P. Berrange wrote: > On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > > A number of different places across the code base use CONFIG_UUID. Some > > of them are soft dependency, some are not built if libuuid is not > > available, some come with dummy fallback,

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Daniel P. Berrange
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to maintain

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Marc-André Lureau
Hi On Thu, Aug 4, 2016 at 4:44 PM Paolo Bonzini wrote: > > > On 03/08/2016 04:36, Fam Zheng wrote: > > On Tue, 08/02 15:45, Paolo Bonzini wrote: > >> > >> > >> - Original Message - > >>> From: "Fam Zheng" > >>> To: qemu-devel@nongnu.org > >>> Cc: f...@redhat.com, berra...@redhat.com, pb

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Paolo Bonzini
On 03/08/2016 04:36, Fam Zheng wrote: > On Tue, 08/02 15:45, Paolo Bonzini wrote: >> >> >> - Original Message - >>> From: "Fam Zheng" >>> To: qemu-devel@nongnu.org >>> Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, >>> kw...@redhat.com, mre...@redhat.com, >>> mdr...@linu

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-02 Thread Jeff Cody
On Wed, Aug 03, 2016 at 10:36:40AM +0800, Fam Zheng wrote: > On Tue, 08/02 15:45, Paolo Bonzini wrote: > > > > > > - Original Message - > > > From: "Fam Zheng" > > > To: qemu-devel@nongnu.org > > > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > > > kw...@redhat.com, mr

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-02 Thread Fam Zheng
On Tue, 08/02 15:45, Paolo Bonzini wrote: > > > - Original Message - > > From: "Fam Zheng" > > To: qemu-devel@nongnu.org > > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > > kw...@redhat.com, mre...@redhat.com, > > mdr...@linux.vnet.ibm.com, arm...@redhat.com, s...@wei

Re: [Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-02 Thread Paolo Bonzini
- Original Message - > From: "Fam Zheng" > To: qemu-devel@nongnu.org > Cc: f...@redhat.com, berra...@redhat.com, pbonz...@redhat.com, > kw...@redhat.com, mre...@redhat.com, > mdr...@linux.vnet.ibm.com, arm...@redhat.com, s...@weilnetz.de, > qemu-bl...@nongnu.org > Sent: Tuesday, August

[Qemu-devel] [PATCH 1/7] util: Add UUID API

2016-08-02 Thread Fam Zheng
A number of different places across the code base use CONFIG_UUID. Some of them are soft dependency, some are not built if libuuid is not available, some come with dummy fallback, some throws runtime error. It is hard to maintain, and hard to reason for users. Since UUID is a simple standard with