Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-16 Thread Jes Sorensen
On 03/16/11 10:15, Alon Levy wrote: > On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote: >>> +typedef struct __attribute__ ((__packed__)) CCID_Header { >>> +uint8_t bMessageType; >>> +uint32_tdwLength; >>> +uint8_t bSlot; >>> +uint8_t bSeq; >>> +} CCID_Hea

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-16 Thread Alon Levy
On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote: > On 02/23/11 12:20, Alon Levy wrote: > > diff --git a/configure b/configure > > index 791b71d..147aab3 100755 > > --- a/configure > > +++ b/configure > > @@ -174,6 +174,7 @@ trace_backend="nop" > > trace_file="trace" > > spice="" > >

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-14 Thread Anthony Liguori
On 03/14/2011 09:07 AM, Daniel P. Berrange wrote: On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote: On 02/23/11 12:20, Alon Levy wrote: diff --git a/configure b/configure index 791b71d..147aab3 100755 --- a/configure +++ b/configure @@ -174,6 +174,7 @@ trace_backend="nop" trace_fi

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-14 Thread Daniel P. Berrange
On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote: > On 02/23/11 12:20, Alon Levy wrote: > > diff --git a/configure b/configure > > index 791b71d..147aab3 100755 > > --- a/configure > > +++ b/configure > > @@ -174,6 +174,7 @@ trace_backend="nop" > > trace_file="trace" > > spice="" > >

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-03-14 Thread Jes Sorensen
On 02/23/11 12:20, Alon Levy wrote: > diff --git a/configure b/configure > index 791b71d..147aab3 100755 > --- a/configure > +++ b/configure > @@ -174,6 +174,7 @@ trace_backend="nop" > trace_file="trace" > spice="" > rbd="" > +smartcard="yes" IMHO smartcard support shouldn't be enabled per defa

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-02-23 Thread Alon Levy
On Tue, Feb 22, 2011 at 10:03:45AM -0600, Anthony Liguori wrote: > On 02/07/2011 10:34 AM, Alon Levy wrote: > >+static int ccid_post_load(void *opaque, int version_id) > >+{ > >+USBCCIDState *s = opaque; > >+ > >+// This must be done after usb_device_attach, which sets state to > >ATTACHED

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-02-23 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-02-22 Thread Anthony Liguori
On 02/07/2011 10:34 AM, Alon Levy wrote: +static int ccid_post_load(void *opaque, int version_id) +{ +USBCCIDState *s = opaque; + +// This must be done after usb_device_attach, which sets state to ATTACHED, +// while it must be DEFAULT in order to accept packets (like it is after +

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-02-07 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-25 Thread Alon Levy
On Tue, Jan 25, 2011 at 08:10:11AM -0600, Anthony Liguori wrote: This review is for v14 - there have been some changes in v15, perhaps you'll want to go over it. This is the change log: v14-v15 changes: * add patch with --enable-smartcard and --disable-smartcard and only disable ccid-card-emu

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-25 Thread Anthony Liguori
On 01/11/2011 02:38 AM, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/de

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-11 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R

[Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-11 Thread Alon Levy
A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1] http://www.usb.org/developers/devclass_docs/DWG_Smart-Card_CCID_R