Re: [Qemu-devel] [PATCH 1/7] qemu-img: Amendment support implies create_opts

2018-05-02 Thread Eric Blake
On 04/21/2018 11:54 AM, Max Reitz wrote: Instead of checking whether a driver has a non-NULL create_opts we should check whether it supports image amendment in the first place. If it does, it must have create_opts. On the other hand, if it does not have create_opts (so it does not support amend

[Qemu-devel] [PATCH 1/7] qemu-img: Amendment support implies create_opts

2018-04-21 Thread Max Reitz
Instead of checking whether a driver has a non-NULL create_opts we should check whether it supports image amendment in the first place. If it does, it must have create_opts. On the other hand, if it does not have create_opts (so it does not support amendment either), the error message "does not s