Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call

2018-03-06 Thread Paolo Bonzini
On 06/03/2018 01:10, David Gibson wrote: > On Mon, Mar 05, 2018 at 09:36:49AM +0100, Paolo Bonzini wrote: >> The MemoryListener is registered on address_space_memory, there is >> not much to assert. This currently works because the callback >> is invoked only once when the listener is registered,

Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call

2018-03-05 Thread Alexey Kardashevskiy
On 05/03/18 19:36, Paolo Bonzini wrote: > The MemoryListener is registered on address_space_memory, there is > not much to assert. This currently works because the callback > is invoked only once when the listener is registered, but section->fv > is the _new_ FlatView, not the old one on later cal

Re: [Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call

2018-03-05 Thread David Gibson
On Mon, Mar 05, 2018 at 09:36:49AM +0100, Paolo Bonzini wrote: > The MemoryListener is registered on address_space_memory, there is > not much to assert. This currently works because the callback > is invoked only once when the listener is registered, but section->fv > is the _new_ FlatView, not t

[Qemu-devel] [PATCH 1/7] openpic_kvm: drop address_space_to_flatview call

2018-03-05 Thread Paolo Bonzini
The MemoryListener is registered on address_space_memory, there is not much to assert. This currently works because the callback is invoked only once when the listener is registered, but section->fv is the _new_ FlatView, not the old one on later calls and that would break. This confines address_