Re: [Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t.

2014-03-28 Thread Luiz Capitulino
On Thu, 27 Mar 2014 22:55:46 +0100 Hani Benhabiles wrote: > On Thu, Mar 27, 2014 at 04:21:51PM -0400, Luiz Capitulino wrote: > > > > I think this patch has to be split into at least three patches. One for > > the drive_del change (which is unrelated with the other stuff), one > > converting devi

Re: [Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t.

2014-03-27 Thread Hani Benhabiles
On Thu, Mar 27, 2014 at 04:21:51PM -0400, Luiz Capitulino wrote: > > I think this patch has to be split into at least three patches. One for > the drive_del change (which is unrelated with the other stuff), one > converting device_add & device_del and the third one converting > object_add and obje

Re: [Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t.

2014-03-27 Thread Luiz Capitulino
On Sun, 9 Mar 2014 12:16:11 +0100 Hani Benhabiles wrote: > Convert device_add, device_del, object_add and object_del commands to use > the new callback. > > Also fix drive_del id argument type to activate completion. I think this patch has to be split into at least three patches. One for the d

[Qemu-devel] [PATCH 1/7] monitor: Add command_completion callback to mon_cmd_t.

2014-03-09 Thread Hani Benhabiles
Convert device_add, device_del, object_add and object_del commands to use the new callback. Also fix drive_del id argument type to activate completion. Signed-off-by: Hani Benhabiles Suggested-by: Luiz Capitulino --- hmp-commands.hx | 6 +- hmp.h | 4 monitor.c | 65