Re: [Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

2014-05-16 Thread Max Reitz
On 16.05.2014 17:09, Eric Blake wrote: On 05/16/2014 08:43 AM, Max Reitz wrote: +source_iotests="$(cd "$(dirname "$(readlink "$0")")"; pwd)" This is potentially dangerous. If readlink or dirname fails, you can invoke cd "" (which on bash is stupidly a no-op instead of an error), and end up

Re: [Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

2014-05-16 Thread Eric Blake
On 05/16/2014 08:43 AM, Max Reitz wrote: >>> +source_iotests="$(cd "$(dirname "$(readlink "$0")")"; pwd)" >> This is potentially dangerous. If readlink or dirname fails, you can >> invoke cd "" (which on bash is stupidly a no-op instead of an error), >> and end up calling pwd in the wrong dire

Re: [Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

2014-05-16 Thread Max Reitz
On 16.05.2014 00:52, Eric Blake wrote: On 05/15/2014 04:26 PM, Max Reitz wrote: As out-of-tree builds are preferred for qemu, running the qemu-iotests in that out-of-tree build should be supported as well. To do so, a symbolic link has to be created pointing to the check script in the source dir

Re: [Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

2014-05-15 Thread Eric Blake
On 05/15/2014 04:26 PM, Max Reitz wrote: > As out-of-tree builds are preferred for qemu, running the qemu-iotests > in that out-of-tree build should be supported as well. To do so, a > symbolic link has to be created pointing to the check script in the > source directory. That script will check whe

[Qemu-devel] [PATCH 1/7] iotests: Allow out-of-tree run

2014-05-15 Thread Max Reitz
As out-of-tree builds are preferred for qemu, running the qemu-iotests in that out-of-tree build should be supported as well. To do so, a symbolic link has to be created pointing to the check script in the source directory. That script will check whether it has been run through a symlink, and if so