Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 15:54, Richard Henderson wrote: On 10/23/18 2:27 PM, Philippe Mathieu-Daudé wrote: +    if re_fullmatch('!extern', t): +    extern = True It looks odd to match a negative form then use a positive one. Why not simply use 'extern'? "!" is an escape character here. Just

Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Richard Henderson
On 10/23/18 2:27 PM, Philippe Mathieu-Daudé wrote: >> +    if re_fullmatch('!extern', t): >> +    extern = True > > It looks odd to match a negative form then use a positive one. > > Why not simply use 'extern'? "!" is an escape character here. Just "escape" would be a field named "e

Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Philippe Mathieu-Daudé
On 23/10/18 14:04, Richard Henderson wrote: Allow argument sets to be shared between two decoders by avoiding a re-declaration error. Make sure that anonymous argument sets have unique names. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 34 +++---

Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Bastian Koppelmann
On 10/23/18 2:04 PM, Richard Henderson wrote: Allow argument sets to be shared between two decoders by avoiding a re-declaration error. Make sure that anonymous argument sets have unique names. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 34 +++-

[Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets

2018-10-23 Thread Richard Henderson
Allow argument sets to be shared between two decoders by avoiding a re-declaration error. Make sure that anonymous argument sets have unique names. Signed-off-by: Richard Henderson --- scripts/decodetree.py | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(