Re: [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-15 Thread Markus Armbruster
Markus Armbruster writes: > And add a declaration to a suitable header :) > > ui/input.c: In function ‘qemu_input_handler_bind’: > ui/input.c:87:11: warning: implicit declaration of function > ‘qemu_console_lookup_by_device_name’ [-Wimplicit-function-declaration] > con = qemu_console_lookup

Re: [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-15 Thread Markus Armbruster
Markus Armbruster writes: > Gerd Hoffmann writes: > >> We have two places needing this, and a third one will come shortly. >> So create a helper function for that so we don't diplicate code. > > "duplicate" > >> >> Signed-off-by: Gerd Hoffmann >> --- >> include/ui/console.h | 2 ++ >> ui/cons

Re: [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-15 Thread Markus Armbruster
Gerd Hoffmann writes: > We have two places needing this, and a third one will come shortly. > So create a helper function for that so we don't diplicate code. "duplicate" > > Signed-off-by: Gerd Hoffmann > --- > include/ui/console.h | 2 ++ > ui/console.c | 23 +++

Re: [Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-12 Thread Daniel P. Berrange
On Tue, Jan 12, 2016 at 01:29:33PM +0100, Gerd Hoffmann wrote: > We have two places needing this, and a third one will come shortly. > So create a helper function for that so we don't diplicate code. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http:/

[Qemu-devel] [PATCH 1/7] console: add qemu_console_lookup_by_device_name

2016-01-12 Thread Gerd Hoffmann
We have two places needing this, and a third one will come shortly. So create a helper function for that so we don't diplicate code. Signed-off-by: Gerd Hoffmann --- include/ui/console.h | 2 ++ ui/console.c | 23 +++ 2 files changed, 25 insertions(+) diff --git a/i