Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-22 Thread Cole Robinson
On 03/22/2014 02:27 PM, Andreas Färber wrote: > Am 12.03.2014 08:22, schrieb Jan Kiszka: >> On 2014-03-12 00:15, Cole Robinson wrote: >>> These errors don't seem user initiated, so forcibly printing to the >>> monitor doesn't seem right. Just print to stderr. >>> >>> Drop lprint since it's now unus

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-22 Thread Andreas Färber
Am 12.03.2014 08:22, schrieb Jan Kiszka: > On 2014-03-12 00:15, Cole Robinson wrote: >> These errors don't seem user initiated, so forcibly printing to the >> monitor doesn't seem right. Just print to stderr. >> >> Drop lprint since it's now unused. >> >> Cc: Jan Kiszka >> Signed-off-by: Cole Robi

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Markus Armbruster
Cole Robinson writes: > On 03/12/2014 04:13 AM, Markus Armbruster wrote: >> Cole Robinson writes: >> >>> These errors don't seem user initiated, so forcibly printing to the >>> monitor doesn't seem right. Just print to stderr. >>> >>> Drop lprint since it's now unused. >>> >>> Cc: Jan Kiszka >

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Cole Robinson
On 03/12/2014 04:13 AM, Markus Armbruster wrote: > Cole Robinson writes: > >> These errors don't seem user initiated, so forcibly printing to the >> monitor doesn't seem right. Just print to stderr. >> >> Drop lprint since it's now unused. >> >> Cc: Jan Kiszka >> Signed-off-by: Cole Robinson >>

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Luiz Capitulino
On Wed, 12 Mar 2014 08:22:05 +0100 Jan Kiszka wrote: > On 2014-03-12 00:15, Cole Robinson wrote: > > These errors don't seem user initiated, so forcibly printing to the > > monitor doesn't seem right. Just print to stderr. > > > > Drop lprint since it's now unused. > > > > Cc: Jan Kiszka > > S

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Markus Armbruster
Cole Robinson writes: > These errors don't seem user initiated, so forcibly printing to the > monitor doesn't seem right. Just print to stderr. > > Drop lprint since it's now unused. > > Cc: Jan Kiszka > Signed-off-by: Cole Robinson > --- > checkpatch flags some pre-existing tab issues, but I d

Re: [Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-12 Thread Jan Kiszka
On 2014-03-12 00:15, Cole Robinson wrote: > These errors don't seem user initiated, so forcibly printing to the > monitor doesn't seem right. Just print to stderr. > > Drop lprint since it's now unused. > > Cc: Jan Kiszka > Signed-off-by: Cole Robinson > --- > checkpatch flags some pre-existing

[Qemu-devel] [PATCH 1/6] slirp: Remove default_mon usage

2014-03-11 Thread Cole Robinson
These errors don't seem user initiated, so forcibly printing to the monitor doesn't seem right. Just print to stderr. Drop lprint since it's now unused. Cc: Jan Kiszka Signed-off-by: Cole Robinson --- checkpatch flags some pre-existing tab issues, but I didn't retab. Should I? slirp/misc.c |