Re: [Qemu-devel] [PATCH 1/6] msix_init: assert programming error

On 08/18/2016 03:14 PM, Markus Armbruster wrote: Cao jin writes: Please explain in the commit message why these are programming errors. If you're unsure how, give it a try in a reply to this message, and we'll hammer out something together. Ok, how about this: The input parameters is

Re: [Qemu-devel] [PATCH 1/6] msix_init: assert programming error

Cao jin writes: > CC: Markus Armbruster > CC: Marcel Apfelbaum > CC: Michael S. Tsirkin > Signed-off-by: Cao jin > --- > hw/pci/msix.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/pci/msix.c b/hw/pci/msix.c > index 0ec1cb1..384a29d 100644 > --- a/hw/pci/m

[Qemu-devel] [PATCH 1/6] msix_init: assert programming error

CC: Markus Armbruster CC: Marcel Apfelbaum CC: Michael S. Tsirkin Signed-off-by: Cao jin --- hw/pci/msix.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/pci/msix.c b/hw/pci/msix.c index 0ec1cb1..384a29d 100644 --- a/hw/pci/msix.c +++ b/hw/pci/msix.c @@ -253,9 +25