Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-22 Thread Richard Henderson
On 12/22/2009 03:27 AM, Laurent Desnogues wrote: +#if TCG_TARGET_REG_BITS == 64 +tcg_gen_op4i_i64(INDEX_op_setcond_i64, ret, arg1, arg2, cond); +#else +tcg_gen_op6i_i32(INDEX_op_setcond2_i32, TCGV_LOW(ret), + TCGV_LOW(arg1), TCGV_HIGH(arg1), + TCGV_

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-22 Thread Laurent Desnogues
On Sat, Dec 19, 2009 at 7:01 PM, Richard Henderson wrote: > Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. > > Signed-off-by: Richard Henderson > --- >  tcg/README    |   20 +++- >  tcg/tcg-op.h  |   47 +++ >  tcg/tcg-opc.h

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 03:24:22PM -0800, Richard Henderson wrote: > On 12/19/2009 03:11 PM, Aurelien Jarno wrote: >> On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: >>> Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. >> >> I do wonder if setcond2_i32 and brcond2_i32

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Richard Henderson
On 12/19/2009 03:11 PM, Aurelien Jarno wrote: On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. I do wonder if setcond2_i32 and brcond2_i32 should be added there. Those are internal ops that are actually not exported

Re: [Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Aurelien Jarno
On Sat, Dec 19, 2009 at 10:01:57AM -0800, Richard Henderson wrote: > Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. I do wonder if setcond2_i32 and brcond2_i32 should be added there. Those are internal ops that are actually not exported in tcg-op.h. > Signed-off-by: Richard Henderso

[Qemu-devel] [PATCH 1/5] tcg: Generic support for conditional set

2009-12-19 Thread Richard Henderson
Defines setcond_{i32,i64} and setcond2_i32 for 64-on-32-bit. Signed-off-by: Richard Henderson --- tcg/README| 20 +++- tcg/tcg-op.h | 47 +++ tcg/tcg-opc.h |3 +++ tcg/tcg.c | 21 +++-- 4 files changed